[CRIU] [PATCH 0/3] crit core-dump feature

Cyrill Gorcunov gorcunov at gmail.com
Mon Apr 27 11:10:11 PDT 2015


On Mon, Apr 27, 2015 at 03:05:10PM +0300, Pavel Emelyanov wrote:
> Cyrill, please, review the patches.
>

While I'm fine with python part, I don't like how we handle
task's command line: in kernel it's NOT limited to 80 symbols
thus one needs to either define

#define ELF_PRARGSZ (80) /* Number of chars for args */

or use predefined constant (I didn't check if it lives in
standart header). 80 bytes is a max allowed in core but
we should save the complete command line in image file
I think (which implies that parse_pid_cmdline should
take accumulator size as well). The kernel itself may
provide up to 4K arguments iirc.

	Cyrill


More information about the CRIU mailing list