[CRIU] [PATCH v2 5/5] introduce --enable-fs cli option

Oleg Nesterov oleg at redhat.com
Fri Apr 10 05:40:17 PDT 2015


On 04/10, Pavel Emelyanov wrote:
>
> On 04/10/2015 02:46 PM, Oleg Nesterov wrote:
> >
> > 	- send v2 which concatenates multiple --enable-fs opts
>
> I would prefer this variant, but no need in v2, incremental patch
> would be enough.

OK, will do today. But.

What should we do if the user does

	$ criu dump --enable-fs all --enable-fs autofs

? Should "all" always win?


And another question... "restore" ignores this option. This is fine,
but perhaps a warning makes sense. Unfortunately main()->getopt_long()
logic doesn't allow to do this simply. Perhaps we should change main()
to require the command in argv[1] ?

Oleg.



More information about the CRIU mailing list