[CRIU] [PATCH v2 5/5] introduce --enable-fs cli option

[Pavel Emelyanov]

On 04/10/2015 02:46 PM, Oleg Nesterov wrote:
> On 04/09, Pavel Emelyanov wrote:
>>
>> I like the set, but one thing worries me
>>
>>> +
>>> +bool add_fsname_auto(const char *names)
>>> +{
>>> +	xfree(fsauto_names);
>>> +	fsauto_names = xstrdup(names);
>>> +	return fsauto_names != NULL;
>>>  }
>>
>> If I do "criu blah-blah --enable-fs xfs --enable-fs yfs --enable-fs zfs"
>> then only zfs will be _silently_ enabled. Can we somehow make this fact
>> be explicit to users?
> 
> Yes, I thought about this... I did it this way because this is how other
> options work. Say,
> 
> 	# criu dump -t 1 -t `pidof perl`
> 
> silently ignores "-t 1".

Yes, but --ext-mount-map and --veth-pair are concatenating.

> So what do you think I should do:
> 
> 	- do nothing because this matches other one-shot options
> 
> 	- send V2 with pr_warn() if fsauto_names != NULL
> 
> 	- send v2 which concatenates multiple --enable-fs opts

I would prefer this variant, but no need in v2, incremental patch
would be enough.

-- Pavel