[CRIU] [PATCH 4/4] prctl: restore -- Use new PR_SET_MM_MAP if kernel supports

[Cyrill Gorcunov]

On Thu, Oct 23, 2014 at 06:09:13PM +0400, Pavel Emelyanov wrote:
> On 10/23/2014 05:58 PM, Cyrill Gorcunov wrote:
> > On Thu, Oct 23, 2014 at 05:43:20PM +0400, Pavel Emelyanov wrote:
> >>
> >> I don't understand the need in args->prctl_may_use_mm_map. Why not just
> >>
> >> ret = prctl(PR_SET_MM< PR_SET_MM_MAP, ...);
> >> if (ret == -EINVAL) {
> >> 	ret = <old code>
> >> }
> > 
> > Same eggs, side view. Look, we need to choose which version to call,
> > thus we choose proper version in kernel-dat, and reuse it for "check"
> > and restore.
> 
> We don't actually need to check this in kerndat. There's no
> point in making one more syscall to check whether it works
> or not.

I think we shold. There is a plan to deprecate old interface completely
in the kernel and then in criu as well. But fine, I'll rework in
the form you prefer.