[CRIU] [PATCH 4/4] prctl: restore -- Use new PR_SET_MM_MAP if kernel supports

Pavel Emelyanov xemul at parallels.com
Thu Oct 23 07:09:13 PDT 2014


On 10/23/2014 05:58 PM, Cyrill Gorcunov wrote:
> On Thu, Oct 23, 2014 at 05:43:20PM +0400, Pavel Emelyanov wrote:
>>
>> I don't understand the need in args->prctl_may_use_mm_map. Why not just
>>
>> ret = prctl(PR_SET_MM< PR_SET_MM_MAP, ...);
>> if (ret == -EINVAL) {
>> 	ret = <old code>
>> }
> 
> Same eggs, side view. Look, we need to choose which version to call,
> thus we choose proper version in kernel-dat, and reuse it for "check"
> and restore.

We don't actually need to check this in kerndat. There's no
point in making one more syscall to check whether it works
or not.



More information about the CRIU mailing list