[CRIU] rewriting images via criu (or crit?)

[Tycho Andersen]

On Tue, Oct 21, 2014 at 05:46:09PM -0400, Christopher Covington wrote:
> On 10/21/2014 08:58 AM, Tycho Andersen wrote:
> > On Tue, Oct 21, 2014 at 01:22:06PM +0400, Cyrill Gorcunov wrote:
> >> On Tue, Oct 21, 2014 at 12:13:06PM +0300, Ruslan Kuprieiev wrote:
> >>>> As to me -- external tool for such modifications is better choise and it seems
> >>>> crit is exactly fits here. This might have slight impact on the speed in compare
> >>>> if the language would builtin into criu itself, but criu is already complex enough
> >>>> so adding language engine here would simply overload I think.
> >>>
> >>> I totally agree with Cyrill.
> >>>
> >>> I like the syntax. Are you thinking about using crit like so:
> >>> crit modify -i cgroup.img cgroup_entry.controllers["cpuset" in
> >>> cnames]//properties[name="cpuset.cpus"] set value=0-1
> >>> right?
> >>
> >> I guess so. Also I would consider introdusing more human-readable
> >> syntax if possible, but that's optional, up to you and Tycho.
> > 
> > Suggestions are welcome; I just picked this because xpath is the only
> > language I could think of that has similar goals, so it might be
> > something that people were familiar with.
> 
> What about just running tools like patch, sed, or awk on the unpacked files?

It seems awfully slow in the case where you only want to change a few
bytes. We'll need to do this during a migration, so it would be best
to have something that was reasonably fast.

Tycho

> Chris
> 
> -- 
> Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project