[CRIU] [PATCH] proc_parse: parse_smaps -- Use @file_path instead of strstr helper, v2
Cyrill Gorcunov
gorcunov at gmail.com
Fri Oct 10 11:31:00 PDT 2014
On Fri, Oct 10, 2014 at 09:58:13PM +0400, Pavel Emelyanov wrote:
> >> There's a code
> >>
> >> if (!strcmp(file_path, "/SYSV")) {
> >> pr_info("path: %s\n", file_path);
> >> vma_area->e->status |= VMA_AREA_SYSVIPC;
> >> }
> >>
> >> beneath your fixes. Does it still work?
> >
> > ipc test passes well, so I think yes. Is there something I'm missing?
>
> I don't understand how. The file_path would contain "/SYSVXXXXX"
> while does strcmp work? Do we have broken tests?
That's the good question. Drop the patch please, I'll investigate the
problem (the kernel indeed generates the name with /SYSV%x format
so there rather should be strncmp(..., 5))
More information about the CRIU
mailing list