[CRIU] [PATCH] proc_parse: parse_smaps -- Use @file_path instead of strstr helper, v2

Pavel Emelyanov xemul at parallels.com
Fri Oct 10 10:58:13 PDT 2014


On 10/10/2014 08:27 PM, Cyrill Gorcunov wrote:
> On Fri, Oct 10, 2014 at 07:49:57PM +0400, Pavel Emelyanov wrote:
>> On 10/10/2014 06:22 PM, Cyrill Gorcunov wrote:
>>> On Fri, Oct 10, 2014 at 06:08:27PM +0400, Pavel Emelyanov wrote:
>>>> On 10/10/2014 03:36 PM, Cyrill Gorcunov wrote:
>>>>> strstr is a really heavy one, lets use already defined
>>>>> and filled @file_path variable instead.
>>>>>
>>>>> Reported-by: Pavel Emelyanov <xemul at parallels.com>
>>>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>>
>>> update
>>>
>>
>> There's a code
>>
>>            if (!strcmp(file_path, "/SYSV")) {
>>                    pr_info("path: %s\n", file_path);
>>                    vma_area->e->status |= VMA_AREA_SYSVIPC;
>>            }
>>
>> beneath your fixes. Does it still work?
> 
> ipc test passes well, so I think yes. Is there something I'm missing?

I don't understand how. The file_path would contain "/SYSVXXXXX"
while does strcmp work? Do we have broken tests?



More information about the CRIU mailing list