[CRIU] [PATCH 00/11] tty: Add c/r for system console

Cyrill Gorcunov gorcunov at gmail.com
Wed Oct 1 08:32:05 PDT 2014


On Wed, Oct 01, 2014 at 07:03:35PM +0400, Andrew Vagin wrote:
> On Mon, Sep 29, 2014 at 08:25:26PM +0400, Cyrill Gorcunov wrote:
> > Hi guys, here is a series which implements c/r for /dev/console,
> > I'm not really sure how to test it -- I simply modified our pty00
> > test case adding
> > 
> > 	console = open("/dev/console", O_RDONLY);
> > 
> > into it to check that c/r flow takes proper branches (and looked
> > into image data).
> > 
> > I guess some help needed presumably attempting to c/r lxc conatiner
> > with /dev/console bound to some readable output.
> > 
> > Anyway, any feedback would be highly appreciated!
> 
> I think we need to support external terminals. It will cover your needs
> and needs of lxc and dockers. I don't think that we should commit this
> series, because we will have problem with backward compatibility in
> future.

We won't have backward compatibility in future simply because this kind
of records are written with own tty-type field _but_ I like idea of
external terminals in terms of "general" solution, thus indeed --
gimme sometime to figure out if it fly (that said don't merge this
series for a while).


More information about the CRIU mailing list