[CRIU] [PATCH 00/11] tty: Add c/r for system console

[Andrew Vagin]

On Mon, Sep 29, 2014 at 08:25:26PM +0400, Cyrill Gorcunov wrote:
> Hi guys, here is a series which implements c/r for /dev/console,
> I'm not really sure how to test it -- I simply modified our pty00
> test case adding
> 
> 	console = open("/dev/console", O_RDONLY);
> 
> into it to check that c/r flow takes proper branches (and looked
> into image data).
> 
> I guess some help needed presumably attempting to c/r lxc conatiner
> with /dev/console bound to some readable output.
> 
> Anyway, any feedback would be highly appreciated!

I think we need to support external terminals. It will cover your needs
and needs of lxc and dockers. I don't think that we should commit this
series, because we will have problem with backward compatibility in
future.


> 
> Cyrill Gorcunov (11):
>   tty: Align members in assignments
>   tty: Instead of BUG_ON exit out with error early
>   tty: Introduce dump_one_tty helper
>   tty: protobuf -- Add CONSOLE type
>   tty: Add some comments about console and bsd terminals
>   tty: Split tty indices into range
>   tty: Rename helpers to reflect the type of peers
>   tty: Carry @minor in tty_info and tty_dump_info
>   tty: Rework tty_type to account minor number
>   tty: collect_one_tty -- Use tty_is_master helper
>   tty: Add dump and restore of /dev/console opened
> 
>  protobuf/tty.proto |   1 +
>  tty.c              | 309 ++++++++++++++++++++++++++++++++++++++++++-----------
>  2 files changed, 247 insertions(+), 63 deletions(-)
> 
> -- 
> 1.9.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu