[CRIU] [PATCH 4/5] vdso: parasite -- Prepare new vdso mark structure.

Cyrill Gorcunov gorcunov at gmail.com
Wed Jun 11 04:47:27 PDT 2014


On Wed, Jun 11, 2014 at 03:43:38PM +0400, Pavel Emelyanov wrote:
> > 
> > You miss the point. The signature _must_ be unique. While "criuvdso",
> > "criuVDSO" is pretty uinique i think, better to escape inventing
> > some more unique values especially those which lays in memory of
> > the dumpee code.
> 
> OK, fair enough. In that case the is_vdso_mark() is wrong. Once
> we've found criuvdso or criuvDSO signature we should validate
> the rest of the fields, not correct our "is it vdso?" assumption.
> 
> In particular, is version != 2 we should abort the dump, not
> treat the found page as non-vdso-proxy.

Yes, there are some nits in parasite_check_vdso_mark caller
as well, I'll update thatnks!


More information about the CRIU mailing list