[CRIU] [PATCH 4/5] vdso: parasite -- Prepare new vdso mark structure.

Cyrill Gorcunov gorcunov at gmail.com
Wed Jun 11 04:34:25 PDT 2014


On Wed, Jun 11, 2014 at 03:29:38PM +0400, Pavel Emelyanov wrote:
> >>
> >>> struct vdso_mark {
> >>>  	u64			signature;
> >>> -	unsigned long		proxy_addr;
> >>> +	unsigned long		proxy_vdso_addr;
> >>> +
> >>> +	unsigned long		version;
> >>
> >> Why do we need the version field? AFAIU the signature is enough.
> > 
> > In case if we need to change it again, we can increase the version
> > instead of changing signature (which is neat in ascii form now ;)
> 
> Please, no. Leave only the signature.

You miss the point. The signature _must_ be unique. While "criuvdso",
"criuVDSO" is pretty uinique i think, better to escape inventing
some more unique values especially those which lays in memory of
the dumpee code.


More information about the CRIU mailing list