[CRIU] [PATCH 4/5] vdso: parasite -- Prepare new vdso mark structure.

[Pavel Emelyanov]

On 06/11/2014 03:28 PM, Cyrill Gorcunov wrote:
> On Wed, Jun 11, 2014 at 03:23:24PM +0400, Pavel Emelyanov wrote:
>> On 06/10/2014 10:16 PM, Cyrill Gorcunov wrote:
>>>
>>> Because of new vvar area we need to carry the
>>> address of vvar proxy inside the mark. Thus
>>> add members needed and update routines.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  arch/x86/include/asm/vdso.h | 36 ++++++++++++++++++++++++++++--------
>>>  arch/x86/vdso-pie.c         |  2 +-
>>>  arch/x86/vdso.c             |  4 ++--
>>>  include/parasite.h          |  3 ++-
>>>  pie/parasite.c              |  6 ++++--
>>>  5 files changed, 37 insertions(+), 14 deletions(-)
>>>
>>
>>
>>> struct vdso_mark {
>>>  	u64			signature;
>>> -	unsigned long		proxy_addr;
>>> +	unsigned long		proxy_vdso_addr;
>>> +
>>> +	unsigned long		version;
>>
>> Why do we need the version field? AFAIU the signature is enough.
> 
> In case if we need to change it again, we can increase the version
> instead of changing signature (which is neat in ascii form now ;)

Please, no. Leave only the signature.