[CRIU] [PATCH 0/3] Plugins engine rework

Cyrill Gorcunov gorcunov at gmail.com
Fri Feb 28 07:25:04 PST 2014


On Fri, Feb 28, 2014 at 07:17:04PM +0400, Andrew Vagin wrote:
> On Thu, Feb 27, 2014 at 10:22:07PM +0400, Cyrill Gorcunov wrote:
> > Hi guys, here is a plugins engine rework, which I suppose
> > is easier to read and maintain. Please review but don't
> > apply -- I've not yet tested it much. Just wanna to
> > gather your opinions.
> 
> This looks correct.
> 
> The current scheme doesn't enumirates all plugins for executing each
> callback, this one does. It can compensate performance benefits, which
> this scheme brings.
> 
> We must fix tests. Maybe one of them should use old scheme for checking
> backward compatibility.

Thanks a lot for review, Andrew! I don't expect perf downgrate here since
we have a small number of dumping points, with time if number of points
increase to 40 and above we would make it a chain hash instead.

And sure, I'll update the tests once it get confirmed that such approach
is suitable for Pavel.


More information about the CRIU mailing list