[CRIU] [PATCH 0/3] Plugins engine rework

[Andrew Vagin]

On Thu, Feb 27, 2014 at 10:22:07PM +0400, Cyrill Gorcunov wrote:
> Hi guys, here is a plugins engine rework, which I suppose
> is easier to read and maintain. Please review but don't
> apply -- I've not yet tested it much. Just wanna to
> gather your opinions.

This looks correct.

The current scheme doesn't enumirates all plugins for executing each
callback, this one does. It can compensate performance benefits, which
this scheme brings.

We must fix tests. Maybe one of them should use old scheme for checking
backward compatibility.

[root at avagin-fc19-cr crtools]# git grep criu-plugin test/
test/ext-links/mvlink.c:#include "criu-plugin.h"
test/mounts/ext/ext-mount.c:#include "criu-plugin.h"
test/unix-callback/syslog-lib.c:#include "criu-plugin.h"
test/unix-callback/unix-lib.c:#include "criu-plugin.h"
test/zdtm/live/static/criu-rtc.c:#include "criu-plugin.h"


Thanks.

> 
> Cyrill Gorcunov (3):
>   plugin: Beautify criu-plugin.h
>   plugin: Rework plugins API
>   plugins: Use new plugins engine
> 
>  files-ext.c           |   4 +-
>  include/criu-plugin.h | 119 ++++++++++++++++++++++++-----
>  include/plugin.h      |  32 ++++++++
>  mount.c               |   6 +-
>  net.c                 |   2 +-
>  plugin.c              | 206 +++++++++++++++++---------------------------------
>  sk-unix.c             |   4 +-
>  7 files changed, 210 insertions(+), 163 deletions(-)
> 
> -- 
> 1.8.3.1