[CRIU] [PATCH 1/2] image: Move image definitions to own file

[Pavel Emelyanov]

On 05/07/2013 11:19 PM, Cyrill Gorcunov wrote:
> On Tue, May 07, 2013 at 11:13:30PM +0400, Pavel Emelyanov wrote:
>> On 05/07/2013 11:08 PM, Cyrill Gorcunov wrote:
>>> On Tue, May 07, 2013 at 10:48:33PM +0400, Pavel Emelyanov wrote:
>>>>
>>>> OK, let's discuss this thing. First -- image-defs.c. It contains the fdset template
>>>> array _only_. Thus I'd name it fdset.c, but I don't understand why the rest of fdset
>>>> management code sits outside of this file. Don't you need it?
>>>
>>> Well, I have own compact fdset code in cpt2, which doesn't need all the stuff
>>> we've in crtools, in particular I don't need shows and such. 
>>
>> And what? Plz use crtools' fdset in your converter, can you?
> 
> I will have to provide useless-stubs which is inconvenient but I can live with
> that. What is worse -- I have to pull-in a number of additional routines such
> as install_service_fd, or number of global variables such as opts (which is
> referred in image.c). That said -- I really though alot before moving
> definitions out of crtools code and made it "abstract" one.

The service fds engine can be detached into separate .c/.h files, so can the opts be.
What to do with ->show callback is nice question, but nonetheless, let's try not
to break fdsets API into pieces.

> .
>