[CRIU] [PATCH 2/2] protobuf: Move protobuf definitions to own files

Pavel Emelyanov xemul at parallels.com
Tue May 7 14:50:37 EDT 2013


On 04/19/2013 12:15 PM, Cyrill Gorcunov wrote:
> 
> In a sake of reusing protobuf code outside of crtools
> code I've moved common definitions to protobuf-defs.[c|h]
> files.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  Makefile.crtools        |   1 +
>  include/protobuf-defs.h | 122 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/protobuf.h      |  76 +----------------------------
>  protobuf-defs.c         | 102 +++++++++++++++++++++++++++++++++++++++
>  protobuf.c              | 124 ------------------------------------------------
>  5 files changed, 227 insertions(+), 198 deletions(-)
>  create mode 100644 include/protobuf-defs.h
>  create mode 100644 protobuf-defs.c
> 


Here you need the cr_pb_message_desc thing (you remove 'static' from it) without
the whole pb_read/write engine. Same as for fdsets in patch #1 -- I'd name it
pb-io.c or smth like this, but don't understand why you need only parts of it.


More information about the CRIU mailing list