[CRIU] [PATCH 06/12] parasite: Create a control socket

[Cyrill Gorcunov]

On Fri, Mar 01, 2013 at 11:12:46PM +0400, Pavel Emelyanov wrote:
> On 03/01/2013 11:08 PM, Cyrill Gorcunov wrote:
> > On Fri, Mar 01, 2013 at 10:48:21PM +0400, Pavel Emelyanov wrote:
> >>
> >>> @@ -20,6 +20,7 @@ struct parasite_ctl {
> >>>  	unsigned int		*addr_cmd;				/* addr for command */
> >>>  	void			*addr_args;				/* address for arguments */
> >>>  	int			tsock;					/* transport socket for transfering fds */
> >>> +	int			ctlsock;				/* control socket for commands */
> >>
> >> Why is it bad to use tsock for that purposes?
> > 
> > Because it become a less clear what is socket used for.
> > control socket serves one purpose -- commands, nothing
> > else, 
> 
> Do we have another socket for acks? No? Why do we mess commands
> with acks then?

commands and acks are the same messages even with same length,
iow they are like commands from both sides.

> > transport socket moves data to and from,
> 
> What data?

File descriptors at the moment. And maybe something else in
future. Frankly I never liked idea of using one socket for
anything, it makes debuggin procedure a way harder.