[CRIU] [PATCH 06/12] parasite: Create a control socket

Pavel Emelyanov xemul at parallels.com
Fri Mar 1 14:12:46 EST 2013


On 03/01/2013 11:08 PM, Cyrill Gorcunov wrote:
> On Fri, Mar 01, 2013 at 10:48:21PM +0400, Pavel Emelyanov wrote:
>>
>>> @@ -20,6 +20,7 @@ struct parasite_ctl {
>>>  	unsigned int		*addr_cmd;				/* addr for command */
>>>  	void			*addr_args;				/* address for arguments */
>>>  	int			tsock;					/* transport socket for transfering fds */
>>> +	int			ctlsock;				/* control socket for commands */
>>
>> Why is it bad to use tsock for that purposes?
> 
> Because it become a less clear what is socket used for.
> control socket serves one purpose -- commands, nothing
> else, 

Do we have another socket for acks? No? Why do we mess commands
with acks then?

> transport socket moves data to and from,

What data?

> lets not mess it.

O_o

Thanks,
Pavel


More information about the CRIU mailing list