[CRIU] [PATCH 2/9] fd: Dynamically allocate args for the array of fds to drain

Cyrill Gorcunov gorcunov at openvz.org
Fri Mar 1 12:11:02 EST 2013


On Fri, Mar 01, 2013 at 08:02:34PM +0400, Pavel Emelyanov wrote:
> --- a/include/parasite.h
> +++ b/include/parasite.h
> @@ -2,7 +2,7 @@
>  #define __CR_PARASITE_H__
>  
>  #define PARASITE_STACK_SIZE	(16 << 10)
> -#define PARASITE_ARG_SIZE_MIN	( 1 << 13)
> +#define PARASITE_ARG_SIZE_MIN	( 1 << 12)

Hmm, I somehow missing, why you change this size again?
In previous patch it's set to 1 << 13, now to 1 << 12.
(Also I think using shift which match to K/M/G is more
easier to read, ie << 10/20/30 and such. Not a big deal
though, could be cleaned up on top.


More information about the CRIU mailing list