[CRIU] [PATCH 1/2] mount: don't destruct an external mount-namespace
Andrew Vagin
avagin at parallels.com
Thu Jul 4 04:32:45 EDT 2013
On Thu, Jul 04, 2013 at 03:24:24PM +0400, Cyrill Gorcunov wrote:
> On Thu, Jul 04, 2013 at 03:21:10PM +0400, Andrey Vagin wrote:
> > @@ -634,6 +634,8 @@ static int do_umount_one(struct mount_info *mi)
> > if (!mi->parent)
> > return 0;
> >
> > + if ( mount("none", mi->parent->mountpoint, "none", MS_REC|MS_PRIVATE, NULL))
> > + pr_perror("Can't mark %s as private", mi->parent->mountpoint);
> > if (umount(mi->mountpoint)) {
> > pr_perror("Can't umount at %s", mi->mountpoint);
> > return -1;
>
> IOW the only point of this patch to print error but continue?
Sorry, I think we try to umount a tree a few times, so I don't handle
errors here. Actually test/zdtm/live/static/mountpoints.c uses this
method and should be fixed too.
More information about the CRIU
mailing list