[CRIU] [PATCH 1/2] mount: don't destruct an external mount-namespace

Pavel Emelyanov xemul at parallels.com
Thu Jul 4 04:27:12 EDT 2013


On 07/04/2013 03:21 PM, Andrey Vagin wrote:
> If a parent mount point is shared with exteranl mntns, a child will be
> umounted from the external mntns too.

I don't understand, please, elaborate.

> This patch changes a parent mnt to private for umounting childrens.
> 
> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  mount.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/mount.c b/mount.c
> index 9e64e4f..b0aaf51 100644
> --- a/mount.c
> +++ b/mount.c
> @@ -634,6 +634,8 @@ static int do_umount_one(struct mount_info *mi)
>  	if (!mi->parent)
>  		return 0;
>  
> +	if ( mount("none", mi->parent->mountpoint, "none", MS_REC|MS_PRIVATE, NULL))
> +		pr_perror("Can't mark %s as private", mi->parent->mountpoint);
>  	if (umount(mi->mountpoint)) {
>  		pr_perror("Can't umount at %s", mi->mountpoint);
>  		return -1;
> 




More information about the CRIU mailing list