[CRIU] [PATCH 3/3] criu-log.h: fit macros in 80 columns

Pavel Emelyanov xemul at parallels.com
Thu Dec 19 23:23:37 PST 2013


On 12/20/2013 01:47 AM, Kir Kolyshkin wrote:
> On 12/19/2013 01:29 PM, Cyrill Gorcunov wrote:
>> On Thu, Dec 19, 2013 at 01:24:29PM -0800, Kir Kolyshkin wrote:
>>> Before this patch, backslash was at 81th column which makes the text
>>> twice longer on a standard 80 col terminal, which is quite annoying.
>> I don't mind about this change, but frankly, Kir, 80 col terminal
>> is definitely some oldtime limit. IIRC there were pretty long conversation
>> on LKML about 80 col limit which (if my memory doesn't betray me) ended
>> up that such limit should be increased up to 90-100 columns.
> 
> Then let's decide on a value and use it.

We're using the same coding style as the Linux kernel community does.
It states that

  "The limit on the length of lines is 80 columns and this is a strongly
   preferred limit.

   Statements longer than 80 columns will be broken into sensible chunks, unless
   exceeding 80 columns significantly increases readability and does not hide
   information."

This patch is worth applying according to this statement.

> There are other places like this that I refrained from patching,
> because they actually do need more than 80 columns. but in
> this very case there's no need to use more than 80 columns.
> 
> .
> 




More information about the CRIU mailing list