[CRIU] [PATCH 3/3] criu-log.h: fit macros in 80 columns

Cyrill Gorcunov gorcunov at gmail.com
Thu Dec 19 13:53:24 PST 2013


On Thu, Dec 19, 2013 at 01:47:49PM -0800, Kir Kolyshkin wrote:
> On 12/19/2013 01:29 PM, Cyrill Gorcunov wrote:
> >On Thu, Dec 19, 2013 at 01:24:29PM -0800, Kir Kolyshkin wrote:
> >>Before this patch, backslash was at 81th column which makes the text
> >>twice longer on a standard 80 col terminal, which is quite annoying.
> >I don't mind about this change, but frankly, Kir, 80 col terminal
> >is definitely some oldtime limit. IIRC there were pretty long conversation
> >on LKML about 80 col limit which (if my memory doesn't betray me) ended
> >up that such limit should be increased up to 90-100 columns.
> 
> Then let's decide on a value and use it.
> 
> There are other places like this that I refrained from patching,
> because they actually do need more than 80 columns. but in
> this very case there's no need to use more than 80 columns.

I personally think 90 cols are just fine. Also in most cases I
guess we're using ~60/70 columns over the CRIU code (it would
be interesting to know the ratio though ;). Still sometime
for long macros we can overflow even 90 columns limit just
to have "\" aligned, and I think that's fine to have some
bound olverflowed in a sake of code geom. structure.


More information about the CRIU mailing list