[CRIU] [PATCH 1/2] image: Move image definitions to own file

Pavel Emelyanov xemul at parallels.com
Tue Apr 23 13:09:17 EDT 2013


On 04/23/2013 09:00 PM, Cyrill Gorcunov wrote:
> On Tue, Apr 23, 2013 at 08:52:44PM +0400, Pavel Emelyanov wrote:
>> On 04/19/2013 12:15 PM, Cyrill Gorcunov wrote:
>>>
>>> To be able to reuse image constants (definitions)
>>> outside of crtools code I need them yank out to
>>> own image-defs.[c|h] files.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  Makefile.crtools     |   1 +
>>>  cr-show.c            |  10 +++++
>>>  image-defs.c         |  77 +++++++++++++++++++++++++++++++++
>>>  image.c              |  77 ---------------------------------
>>>  include/cr-show.h    |  54 ++++++++++++++++++++++++
>>>  include/crtools.h    | 117 ---------------------------------------------------
>>>  include/image-defs.h | 105 +++++++++++++++++++++++++++++++++++++++++++++
>>
>> For this case -defs suffix sounds like "can't find proper name".
>> Plz, think again, maybe some better one exists.
>>
>> Same for patch #2.
> 
> Ahem... I must admit, yes, I've not found any suitable name for that
> and desided to stick with some abstract "def"initions. But sure, I'll
> think more on that. Drop the series for a whil then.

Why drop? Let's come up with  better name and I'll do sed -e 's///' on patch.

> 	Cyrill
> .
> 




More information about the CRIU mailing list