[CRIU] [PATCH 2/3] make: Don't generate tags/cscope for tools/ and test/

Andrew Vagin avagin at parallels.com
Thu Apr 18 07:22:24 EDT 2013


On Thu, Apr 18, 2013 at 02:41:39PM +0400, Cyrill Gorcunov wrote:
> On Thu, Apr 18, 2013 at 02:40:25PM +0400, Cyrill Gorcunov wrote:
> > On Thu, Apr 18, 2013 at 02:31:51PM +0400, Andrew Vagin wrote:
> > > I hate this patch! Why do you decide to not generate tags for tests?
> > > I used this functionality very often, it was useful. In which situation
> > > is it inconvenient?
> > 
> > The test code has nothing to do with crtools code, thus when I walk
> > over crtools sources I see no reason to receive a list of same named
> > functions (for example lock helpers and such).
> > 
> > If you need tags for test, I think we better provide targets for that.
> > tags:
> > 	only crtools sources are visited
> > tags-all:
> > 	everything including tests
> 
> Look into kernel code -- we don't generate tags for _all_ architectures

It is not the same...

> unless explicitly requested!

You don't answer on my question:(. Interseption beetwen crtools and
tests functions is too small for such changes. I don't want to argue,
it is just my opinion.

> 
> 	Cyrill


More information about the CRIU mailing list