[CRIU] [PATCH 14/32] tools: cpt2 -- Start reading dumpfile

[Pavel Emelyanov]

On 04/01/2013 02:39 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 01, 2013 at 02:05:10PM +0400, Pavel Emelyanov wrote:
>>> +	version = CPT_VERSION_MAJOR(ctx->h.cpt_image_version);
>>> +	if ((version == CPT_VERSION_18 &&
>>> +	    (ctx->h.cpt_image_version < CPT_VERSION_18_3)) ||
>>> +	    (version == CPT_VERSION_32 &&
>>> +	     (CPT_VERSION_MINOR(ctx->h.cpt_image_version) >
>>> +	      CPT_VERSION_MINOR(CPT_CURRENT_VERSION)))) {
>>> +		pr_err("Unsupported image version %d:%d\n",
>>> +		       CPT_VERSION_MAJOR(ctx->h.cpt_image_version),
>>> +		       CPT_VERSION_MINOR(ctx->h.cpt_image_version));
>>> +		return -1;
>>> +	}
>>
>> You copied it from the kernel? Have you _really_ checked, that you could
>> convert every single image, that matched this if?
> 
> Yes, I took it from kernel code, and no I didn't check, I assume
> kernel code is well tested already.

It's not about kernel code being tested or not. It's about _your_
converted being able to convert images from e.g. 2.6.18. Can it?
I _really_ doubt.

> .
>