[CRIU] [PATCH 14/32] tools: cpt2 -- Start reading dumpfile

Cyrill Gorcunov gorcunov at openvz.org
Mon Apr 1 06:39:48 EDT 2013


On Mon, Apr 01, 2013 at 02:05:10PM +0400, Pavel Emelyanov wrote:
> > +	version = CPT_VERSION_MAJOR(ctx->h.cpt_image_version);
> > +	if ((version == CPT_VERSION_18 &&
> > +	    (ctx->h.cpt_image_version < CPT_VERSION_18_3)) ||
> > +	    (version == CPT_VERSION_32 &&
> > +	     (CPT_VERSION_MINOR(ctx->h.cpt_image_version) >
> > +	      CPT_VERSION_MINOR(CPT_CURRENT_VERSION)))) {
> > +		pr_err("Unsupported image version %d:%d\n",
> > +		       CPT_VERSION_MAJOR(ctx->h.cpt_image_version),
> > +		       CPT_VERSION_MINOR(ctx->h.cpt_image_version));
> > +		return -1;
> > +	}
> 
> You copied it from the kernel? Have you _really_ checked, that you could
> convert every single image, that matched this if?

Yes, I took it from kernel code, and no I didn't check, I assume
kernel code is well tested already.


More information about the CRIU mailing list