[CRIU] Re: [PATCH 1/2] pipes: Restore file params on received pipes

Cyrill Gorcunov gorcunov at openvz.org
Thu May 31 07:27:49 EDT 2012


On Thu, May 31, 2012 at 03:14:50PM +0400, Pavel Emelyanov wrote:
> >  
> > -	if (restore_fown(fd, &pi->pe.fown))
> > +	if (rst_file_params(fd, &pi->pe.fown, pi->pe.flags))
> 
> With the pi->pe.flags this fd is being opened. What exact flags are lost?

Yes, this is redundant, the miss of O_ASYNC in set_fd_flags was the key
reason why fown test case failed. Drop this patch please.

	Cyrill


More information about the CRIU mailing list