[CRIU] Re: [PATCH 1/2] pipes: Restore file params on received pipes

[Pavel Emelyanov]

On 05/30/2012 09:06 PM, Cyrill Gorcunov wrote:
> While've been poking file_fown test case I've
> found that flags on pipes are not restored properly.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  pipes.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/pipes.c b/pipes.c
> index 85f4bd7..26111c8 100644
> --- a/pipes.c
> +++ b/pipes.c
> @@ -206,7 +206,7 @@ static int recv_pipe_fd(struct pipe_info *pi)
>  	fd = open(path, pi->pe.flags);
>  	close(tmp);
>  
> -	if (restore_fown(fd, &pi->pe.fown))
> +	if (rst_file_params(fd, &pi->pe.fown, pi->pe.flags))

With the pi->pe.flags this fd is being opened. What exact flags are lost?

>  		return -1;
>  
>  	return fd;