[CRIU] Re: [PATCH 3/6] make: Redesign building of parasite and restorer blobs

Cyrill Gorcunov gorcunov at openvz.org
Wed Mar 28 06:56:19 EDT 2012


On Wed, Mar 28, 2012 at 02:51:03PM +0400, Pavel Emelyanov wrote:
> On 03/28/2012 02:21 PM, Cyrill Gorcunov wrote:
> > On Wed, Mar 28, 2012 at 01:53:42PM +0400, Pavel Emelyanov wrote:
> >>>> What are the rules?
> >>>
> >>> -fpie and only one .text section with everything else discarded.
> >>
> >> And why do we need separate Makefile for this then?
> > 
> > Because squashing everything into one big makefile is a bad idea.
> > It's hard to review and hard to understand.
> 
> It's only a couple of cflags for several particular .o files, no?

Not only, it's also running ld and generate blob files.

Also here is a thing which I really hate but we've to live
with it -- util-net.c compiled into parasite-util-net.o, while main
Makefile compiles this .c file with different flags and generates
util-net.o, so a separate file should increase readability I think.

	Cyrill


More information about the CRIU mailing list