[CRIU] Re: [PATCH 3/6] make: Redesign building of parasite and restorer blobs

[Pavel Emelyanov]

On 03/28/2012 02:21 PM, Cyrill Gorcunov wrote:
> On Wed, Mar 28, 2012 at 01:53:42PM +0400, Pavel Emelyanov wrote:
>>>> What are the rules?
>>>
>>> -fpie and only one .text section with everything else discarded.
>>
>> And why do we need separate Makefile for this then?
> 
> Because squashing everything into one big makefile is a bad idea.
> It's hard to review and hard to understand.

It's only a couple of cflags for several particular .o files, no?

>>>
>>> symbol names has nothing to do with ld script, the symbols are
>>> generated from source code and ld doesn't touch them.
>>
>> In the parasite.lds there's the *(.parasite.head.text) statement, in the
>> restorer.lds -- the *(.restorer.head.text) one.
>>
>> Why do you create one pie.lds file for both with *(.parasite.head.text)?
>>
> 
> The .restorer.head.text is a rudiment from early prototype and not needed.
> And I think I need to rename parasite.head.text to plain head.text
> (since I'll be redoing the series anyway I'll do that).
> 
>>> Sure this one can be done in separate patch, but Pavel it's
>>> just one line in makefile, where makefile is completely rewritten
>>> so there is NO benefit in patching it separately.
>>
>> Anyway.
> 
> Ok
> 
> 	Cyrill
> .
>