[CRIU] Re: [PATCH 2/4] protobuf: Start switching our image entries to Google's protobuf

[Cyrill Gorcunov]

On Fri, Jul 06, 2012 at 07:45:13PM +0400, Pavel Emelyanov wrote:
> > diff --git a/protobuf/regfile.proto b/protobuf/regfile.proto
> > new file mode 100644
> > index 0000000..7efac6c
> > --- /dev/null
> > +++ b/protobuf/regfile.proto
> > @@ -0,0 +1,10 @@
> > +import "fown.proto";
> > +
> > +message reg_file_entry {
> > +	required uint32		id	= 1;
> > +	required uint32		flags	= 2;
> > +	required uint64		pos	= 3;
> > +	required uint32		len	= 4;
> 
> Do we need the len still?

Good question, at first I wanted to map it 1:1,
but it seems indeed being redundant with proto
approach. Will update.

> 
> > +	required fown_t		fown	= 5;
> > +	optional string		name	= 6;
> 
> Why optional?

Well, initially I thought if we could pass null'ed
name here, but otoh indeed there is no files without
name. will change thanks!

> 
> > +}
> 
> > +message fown_t {
> 
> fown_entry

ok

> All .proto files should go with patches changing foo_entry into FooEntry.

ok, will redo.

	Cyrill