[CRIU] Re: [PATCH 2/4] protobuf: Start switching our image entries to Google's protobuf

[Pavel Emelyanov]

> diff --git a/protobuf/regfile.proto b/protobuf/regfile.proto
> new file mode 100644
> index 0000000..7efac6c
> --- /dev/null
> +++ b/protobuf/regfile.proto
> @@ -0,0 +1,10 @@
> +import "fown.proto";
> +
> +message reg_file_entry {
> +	required uint32		id	= 1;
> +	required uint32		flags	= 2;
> +	required uint64		pos	= 3;
> +	required uint32		len	= 4;

Do we need the len still?

> +	required fown_t		fown	= 5;
> +	optional string		name	= 6;

Why optional?

> +}

> +message fown_t {

fown_entry

> +	required uint32	uid		= 1;
> +	required uint32	euid		= 2;
> +	required uint32	signum		= 3;
> +	required uint32	pid_type	= 4;
> +	required uint32	pid		= 5;
> +}


All .proto files should go with patches changing foo_entry into FooEntry.

Thanks,
Pavel