[CRIU] Re: [PATCH 0/3] Protobuf first step

Cyrill Gorcunov gorcunov at openvz.org
Wed Jul 4 04:45:43 EDT 2012


On Wed, Jul 04, 2012 at 12:43:21PM +0400, Stanislav Kinsbursky wrote:
> Kirill, sorry, but it's nearly impossible to me to review all the
> protobuf structures right now (it'll take a lot of time, which I
> don't have right now).

ok :)

> I'd prefer the following:
> 1) Make separated protobuf file for each object. We have special
> directory "protobuf/" and this approach will simplify patches review
> and further code development.

sure

> 2) Port images to protobuf one by one. I.e. if you introduce only
> fdinfo_entry, then it's protobuf representation is the only
> required.
> 
> I'll comment the patches themselves too.

ok, thanks

	Cyrill


More information about the CRIU mailing list