[CRIU] Re: [PATCH 0/3] Protobuf first step

[Stanislav Kinsbursky]

04.07.2012 11:43, Cyrill Gorcunov пишет:
> On Wed, Jul 04, 2012 at 11:40:42AM +0400, Pavel Emelyanov wrote:
>> On 07/04/2012 11:37 AM, Cyrill Gorcunov wrote:
>>> Hi guys, just to share what've been done -- here is a series
>>> which passes all tests, see details in changelogs and tell me
>>> what you think.
>>
>> Stas, I need your pre-review on the whole protobuffer work including
>> these patches.
>
> Yeah, Stas I would really appreciate if you check the .proto files, that
> is the most important change.
>
> Btw, dealing with .proto files I found that it could be more preferred
> to use "fixed" types for our u32/u64 entries since then protobuf doesn't
> pack/unpack them. Stas, what you think?
>
> 	Cyrill
>

Kirill, sorry, but it's nearly impossible to me to review all the protobuf 
structures right now (it'll take a lot of time, which I don't have right now).
I'd prefer the following:
1) Make separated protobuf file for each object. We have special directory 
"protobuf/" and this approach will simplify patches review and further code 
development.
2) Port images to protobuf one by one. I.e. if you introduce only fdinfo_entry, 
then it's protobuf representation is the only required.

I'll comment the patches themselves too.

-- 
Best regards,
Stanislav Kinsbursky