[CRIU] Re: [PATCH 1/2] Move printk helpers to a separate file

Pavel Emelyanov xemul at parallels.com
Tue Feb 7 03:13:45 EST 2012


On 02/07/2012 01:36 AM, Cyrill Gorcunov wrote:
> util.c is overdoes already so move printk
> helpers to own printk.[ch].

Let's at the same time do "s/printk/print${some-other-letter-with-sense}/g".

> This patch also introduces printk_perror
> helper which may handle '\n' at the end
> of the message format and append it after
> the %m specificator (see commit
> 0b237ae9f2ad49499f7c9c1b3713c13267aca309
> for rationale).
> 
> The idea behind is to eliminate special
> call-form of pr_perror (which at moment
> implies that \n will be appended implicitly)
> and do not print \n out until explicitly
> stated.
> 
> Based-on-patch-from: Kir Kolyshkin <kir at openvz.org>
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>


More information about the CRIU mailing list