[CRIU] [PATCH 01/20] x86: moved x86-specific files into the directory arch/x86.

Alexander Kartashov alekskartashov at parallels.com
Thu Dec 13 01:39:45 EST 2012


On 12/12/2012 07:51 PM, Cyrill Gorcunov wrote:
>> An overall note on the file names -- it's ugly, when a file name is arch/xxx/arch-yyy.h.
>> >Please, rework the arch-dependent headers model the way it looks in the Linux kernel.
>> >
>> >I.e.
>> >- files look like arch/<arch>/include/asm/<file>.h
>> >- everyone who need arch-specific header does #include <asm/<file>.h>
>> >- the -I arch/<arch/include/ option is added by builder
> Yes, I was about to propose the same. Everything arch-dependant should go
> to arch/x86/include and/or arch/arm/include.

Is the proposal adopted? If not I'd like to hear your comments about the 
following proposal:
I'd like to introduce intermediate include folder into 
arch/<arch>/include/cr in order to avoid
collisions between arch-dependent, arch-independent and system headers: 
some arch-dependent
headers (eg. atomic.h, types.h) have very generic name and they collide 
with system header names.

-- 
Sincerely yours,
Alexander Kartashov

Intern
Core team

www.parallels.com

Skype: aleksandr.kartashov
Email: alekskartashov at parallels.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openvz.org/pipermail/criu/attachments/20121213/e910006c/attachment.html>


More information about the CRIU mailing list