[CRIU] [PATCH 01/20] x86: moved x86-specific files into the directory arch/x86.

Cyrill Gorcunov gorcunov at openvz.org
Wed Dec 12 10:51:58 EST 2012


On Wed, Dec 12, 2012 at 07:43:11PM +0400, Pavel Emelyanov wrote:
> 
> > diff --git a/arch/x86/arch-types.h b/arch/x86/arch-types.h
> > new file mode 100644
> > index 0000000..ac99ee4
> > --- /dev/null
> > +++ b/arch/x86/arch-types.h
> 
> An overall note on the file names -- it's ugly, when a file name is arch/xxx/arch-yyy.h.
> Please, rework the arch-dependent headers model the way it looks in the Linux kernel.
> 
> I.e.
> - files look like arch/<arch>/include/asm/<file>.h
> - everyone who need arch-specific header does #include <asm/<file>.h>
> - the -I arch/<arch/include/ option is added by builder

Yes, I was about to propose the same. Everything arch-dependant should go
to arch/x86/include and/or arch/arm/include.

	Cyrill


More information about the CRIU mailing list