[CRIU] [PATCH 07/20] parasite: introduced the multiarch support into the parasite.

Pavel Emelyanov xemul at parallels.com
Wed Dec 12 10:52:08 EST 2012


> @@ -192,14 +190,14 @@ static int dump_pages(struct parasite_dump_pages_args *args)
>  
>  	ret = 0;
>  	for (pfn = 0; pfn < nrpages; pfn++) {
> -		unsigned long vaddr;
> +		size_t vaddr;

Plz, explain this part.

>  
>  		if (should_dump_page(&args->vma_entry, map[pfn])) {
>  			/*
>  			 * That's the optimized write of
>  			 * page_entry structure, see image.h
>  			 */
> -			vaddr = (unsigned long)args->vma_entry.start + pfn * PAGE_SIZE;
> +			vaddr = (size_t)args->vma_entry.start + pfn * PAGE_SIZE;
>  
>  			ret = sys_write_safe(fd_pages, &vaddr, sizeof(vaddr));
>  			if (ret)
> @@ -286,7 +284,7 @@ static int dump_misc(struct parasite_dump_misc *args)
>  
>  	args->pid = sys_getpid();
>  	args->sid = sys_getsid();
> -	args->pgid = sys_getpgid();
> +	args->pgid = sys_getpgid(0);

Huh? I haven't seen the sys_getpgid() change in x86/ syscall.def file.

>  
>  	return 0;
>  }


More information about the CRIU mailing list