[CRIU] [PATCH 07/20] parasite: introduced the multiarch support into the parasite.

Pavel Emelyanov xemul at parallels.com
Wed Dec 12 10:50:58 EST 2012


> @@ -416,9 +357,17 @@ err:
>  	return -1;
>  }
>  
> +
> +#ifndef CONFIG_HAS_TLS
>  int parasite_dump_thread_seized(struct parasite_ctl *ctl, pid_t pid,
>  					unsigned int **tid_addr, pid_t *tid,
>  					void *blocked)
> +#else
> +int parasite_dump_thread_seized(struct parasite_ctl *ctl, pid_t pid,
> +					unsigned int **tid_addr, pid_t *tid,
> +					void *blocked,
> +					u32* tls)
> +#endif

No, no, no, this is too ugly. Better repatch the parasite_dump_thread_seized to
work on opaque arg pointer, rather than a arch-depening set of arguments.

>  {
>  	struct parasite_dump_thread *args;
>  	int ret;

> @@ -584,6 +586,12 @@ static int parasite_cfg_log(struct parasite_log_args *args)
>  	return ret;
>  }
>  
> +#ifdef CONFIG_HAS_TLS
> +static void parasite_get_tls(struct parasite_get_tls_args* args) {

Follow the kernel coding style conventions please.

> +	args->tls = get_tls();
> +}
> +#endif
> +
>  static int fini(void)
>  {
>  	int ret;


More information about the CRIU mailing list