[CRIU] Re: [PATCH]

Cyrill Gorcunov gorcunov at openvz.org
Thu Apr 5 09:19:20 EDT 2012


On Thu, Apr 05, 2012 at 05:13:34PM +0400, Cyrill Gorcunov wrote:
> > 
> > I'm really confused.
> > Git commit d1df3f60 did exactly the same. But this code part was
> > rewritten several times already (I missed these patches).
> > Or I'm missing something?
> > 
> 
> No, it didn't (it should actually :). There were a typo in
> commit, the variable should be referenced as $() clause.
> And the second, it didn't take into account empty make goal.
> 

Stas, I guess you miss that there two cases which patch handles

 - the goal is one of *.o,*.s,*.i,crtools,zdtm,test-legacy,
   so _ifNeq_ will give you non-epmty result on filtering,
   thus deps are needed

 - the goal was not specified at all, thus MAKECMDGOALS is
   empty and we need deps as well since, this is "all" target.

	Cyrill


More information about the CRIU mailing list