[CRIU] Re: [PATCH]

Cyrill Gorcunov gorcunov at openvz.org
Thu Apr 5 09:13:34 EDT 2012


On Thu, Apr 05, 2012 at 05:09:35PM +0400, Kinsbursky Stanislav wrote:
> 05.04.2012 17:02, Cyrill Gorcunov пишет:
> >Guys, while being mocking with root Makefile I found that
> >filtering of goals is not going fine, ie "make clean" called
> >twice in a row forced make to generate deps, which is useless
> >of course.
> >
> >So the fix is below, please review. The idea is to generate
> >deps IIF they are really needed, which are the cases
> >
> >  - one of *.o,*.s,*.i file is about to build
> >  - one of general targets such as crtools,zdtm,test-legacy
> >    acquired
> >
> >anything else (including clean,docs and such) should not
> >generate deps, saving cpu cycles ;)
> 
> I'm really confused.
> Git commit d1df3f60 did exactly the same. But this code part was
> rewritten several times already (I missed these patches).
> Or I'm missing something?
> 

No, it didn't (it should actually :). There were a typo in
commit, the variable should be referenced as $() clause.
And the second, it didn't take into account empty make goal.

	Cyrill


More information about the CRIU mailing list