[Devel] [PATCH hci-8.1 2/2] ms/selftests: cgroup: make test_memcg_sock check flushed sock stats

[no-reply at sashiko.virtuozzo.com]

> test_memcg_sock compares memory.current with the "sock " entry of
> memory.stat. memory.current changes at charge time, "sock " only when
> the memcg stats are flushed: by a memory.stat read once enough updates
> are pending (MEMCG_CHARGE_BATCH per online CPU), or by a periodic,
> deferrable worker. Nothing in the test makes sure a flush happens:
> 
> - tcp_client() takes 16 readings right after connect(). If no flush
>   lands among them, "sock " reads 0, and the test either passes on
>   0 == 0 without checking anything or, once memory.current shows the
>   first charge, cannot pass any more and fails:
> 
>     not ok 11 test_memcg_sock
> 
> - The final check waits 3 seconds for "sock " to drop to 0, counting on
>   the deferrable worker, which can run later than that on an idle
> [ ... ]
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-149854
> 
> Feature: fix selftests
> Signed-off-by: Konstantin Khorenko <khorenko at virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261019-b4-prep-khorenko-vstor-149854-selftests-test_memcg_sock-v1-0-efbfa45dc967@virtuozzo.com?part=2