[Devel] [PATCH hci-8.1 v2 1/6] ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS
no-reply at sashiko.virtuozzo.com
no-reply at sashiko.virtuozzo.com
Mon Oct 19 03:12:06 MSK 2026
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] kconfig: stale CONFIG_GENERIC_VDSO_TIME_NS=y left in shipped x86_64 configs
--
commit 58fc0fc4b4942154ef41adeca15ad8a7447eb83c
Author: Eva Kurchatova <eva.kurchatova at virtuozzo.com>
ms/vdso: Drop Kconfig GENERIC_VDSO_TIME_NS
This commit is a cherry-pick of upstream bad53ae2dc42. It removes the
GENERIC_VDSO_TIME_NS Kconfig symbol and every select of it. TIME_NS now
depends on GENERIC_GETTIMEOFDAY instead.
Link: https://lore.kernel.org/all/20250826-vdso-cleanups-v1-10-d9b65750e49f@linutronix.de
> diff --git a/lib/vdso/Kconfig b/lib/vdso/Kconfig
> index 45df764b49ad6..a1cc90133cb9e 100644
> --- a/lib/vdso/Kconfig
> +++ b/lib/vdso/Kconfig
> @@ -24,12 +24,6 @@ config GENERIC_COMPAT_VDSO
> help
> This config option enables the compat VDSO layer.
>
> -config GENERIC_VDSO_TIME_NS
> - bool
> - help
> - Selected by architectures which support time namespaces in the
> - VDSO
> -
> config GENERIC_VDSO_OVERFLOW_PROTECT
> bool
> help
[Severity: Low]
This patch removes config GENERIC_VDSO_TIME_NS, but the shipped x86_64
configs still set it. Should those two entries be dropped too?
configs/kernel-6.12.0-x86_64.config:
CONFIG_GENERIC_VDSO_TIME_NS=y
configs/kernel-6.12.0-x86_64-debug.config:
CONFIG_GENERIC_VDSO_TIME_NS=y
A git grep at the end of the series still finds the symbol in both files.
The series does remove it from config.vz10.minimal, so only these two files
remain.
Kconfig ignores unknown symbols during oldconfig and olddefconfig, so I
don't expect a build or runtime effect. A config-sync or diff check may
report the two lines as stale.
--
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261019000649.1371025-1-eva.kurchatova@virtuozzo.com?part=1
More information about the Devel
mailing list