[Devel] [PATCH hci-8.1 v6 10/12] dm-ploop: fix flip_upper_deltas racing with resume

no-reply at sashiko.virtuozzo.com no-reply at sashiko.virtuozzo.com
Tue Oct 13 14:28:05 MSK 2026


> ploop_preresume() checks noresume under ctl_rwsem, drops the lock and
> only then clears ->suspended. Messages are not serialized with resume:
> target_message() uses the live table without md->suspend_lock, so
> "set_noresume 1" followed by "flip_upper_deltas" can pass the check
> in ploop_flip_upper_deltas() in that gap. The device then goes live
> with noresume set and the top deltas swapped.
> 
> Clear ->suspended in the same critical section as the noresume check,
> and only if it passes.

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261013111604.142989-1-alexander.ivanov@virtuozzo.com?part=10




More information about the Devel mailing list