[Devel] [PATCH hci-8.1 v2 3/7] dm-qcow2: prepare process_one_qio() for fastpath
Konstantin Khorenko
khorenko at virtuozzo.com
Tue Nov 10 20:56:36 MSK 2026
I won't apply this version, please send v3 with the changes below.
On Tue, 10 Nov 2026 14:46:25 +0300, Andrey Zhadchenko wrote:
> + if (avoid_metadata_changes)
> + return QIO_NEEDS_MAIN_KWORK;
No code changes in this patch for v3. On your answer to Sashiko about
the discard race, handled by item 3 of the cover letter reply:
- "The same scenario is possible for base dm-qcow2" holds only on
FUSE. On ext4 and xfs main kwork parses and submits a write in one
call, so its direct I/O is in flight before the discard is even
parsed, and the punch hole waits for it in inode_dio_wait().
fuse_file_fallocate() does not wait for direct I/O.
- "It should outsleep two inode-wide exclusive locks" does not cover a
fast worker that has parsed but not yet entered the filesystem: the
inode locks do not see it at all.
The window is new and needs a guest discarding and accessing the same
cluster at once, so a follow-up series is fine with me, as agreed. Say
it in the patches (item 3), and keep the switch of item 2 for the time
until it is fixed.
--
Konstantin Khorenko,
Virtuozzo Linux Kernel Team
More information about the Devel
mailing list