[Devel] [PATCH hci-8.1 v9 08/10] dm-qcow2: flag the image for check if reftable relocation fails late
Alexander Ivanov
alexander.ivanov at virtuozzo.com
Mon Nov 9 12:17:01 MSK 2026
> I won't apply this version, please send v10 with the changes below.
>
> On 10/28/26 16:06, Alexander Ivanov wrote:
>> +err_hdr_written:
>> + QC_ERR(qcow2->tgt->ti, "failed to relocate refcount table");
>> + qcow2->tgt->md_writeback_error = true;
>> + return -EIO;
> - Make the two messages differ and print the error code.
>
> You answered that a WARN before every late failure tells the two
> apart. The header write failure has no WARN, and the late paths use
> WARN_ON_ONCE. So from the second failure on, both cases print the same
> single line, and the error of the header write is not printed at all.
The two messages now differ:
"failed to write header with relocated refcount table: %d" with the
error of the header write, and "failed to fill relocated refcount
table: %d" for the failures after it. Each late path now sets the
error it prints; a page missing from the cache is reported as -ENOENT.
More information about the Devel
mailing list