[Devel] [PATCH hci-8.1 3/8] ms/mptcp: move the stale logic out of retrans scheduler

[no-reply at sashiko.virtuozzo.com]

> From: Paolo Abeni <pabeni at redhat.com>
> 
> This allow separating the stale logic invocation and the retrans
> scheduler, and will simplify the next patch.
> 
> It's also a cleaner design as the retrans scheduler has currently
> too many side effects. As a possible downside, the retrans work will
> now traverse the subflows list additional times; that does not matter
> much, as this is slowpath.
> 
> While at it, pick more accurate names for the involved helpers and
> explicitly note that the per subflow stale data is under msk socket
> lock protection.
> 
> The scheduler and the stale logic may observe different subflow
> [ ... ]
> "stale" bit leaves the bitfield, and __unused grows from 9 to 10.
> 
> https://virtuozzo.atlassian.net/browse/VSTOR-153491
> Feature: fix ms/net
> Signed-off-by: Eva Kurchatova <eva.kurchatova at virtuozzo.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.vzint.dev/#/patchset/20261106030306.16014-1-eva.kurchatova@virtuozzo.com?part=3