[Devel] [PATCH hci-8.1 1/2] dm-ploop: fix flip_upper_deltas returning with two md_locks held

Konstantin Khorenko khorenko at virtuozzo.com
Thu Nov 5 15:58:48 MSK 2026


I won't apply this version, please send v2 with the changes below.

On Wed, 04 Nov 2026 22:46:34 +0100, Denis V. Lunev wrote:
> there. The ploop library does not: its reverse merge clears those
> entries in the lower delta before it flips, and a device it mounted has
> the lower delta read-only, which the flip refuses before the check.

- drop "and a device it mounted has the lower delta read-only, which the
  flip refuses before the check".

Item 1 of the cover letter reply. The library reloads the table with
PLOOP_RELOAD_RW2 before the flip, so the lower delta is read-write and
the check runs on every library flip. Clearing the shared entries with
the device suspended is what keeps the library away from this path.

The code is fine. With that fixed:

Reviewed-by: Konstantin Khorenko <khorenko at virtuozzo.com>

-- 
Konstantin Khorenko,
Virtuozzo Linux Kernel Team



More information about the Devel mailing list